tweise commented on a change in pull request #2105:
URL: https://github.com/apache/iceberg/pull/2105#discussion_r572488364



##########
File path: build.gradle
##########
@@ -317,19 +317,23 @@ project(':iceberg-flink') {
     compile project(':iceberg-parquet')
     compile project(':iceberg-hive-metastore')
 
+    compileOnly "org.apache.flink:flink-connector-base"

Review comment:
       Regarding the dup classes: The the user still has control over the 
transitive dependency if there is a version mismatch (which is why it should be 
a transitive dependency and not included via shadow).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to