jackye1995 commented on pull request #2214: URL: https://github.com/apache/iceberg/pull/2214#issuecomment-781103072
The code change looks good to me, but I am a bit confused about the scope of this PR (I only read the Spark path, but the same applies to Flink). In `SparkAppenderFactory`, only the constructor and `newEqDeleteWriter` are updated, but `newDataWriter` is not updated. The callers of the methods up to `SparkWrite.WriterFactory` are not updated to include sort order, so the methods you updated are basically not used. Do you plan to add all those things in another PR? I feel we can just add them here, based on what your title suggests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
