yyanyy commented on a change in pull request #2214:
URL: https://github.com/apache/iceberg/pull/2214#discussion_r593553216
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/SparkAppenderFactory.java
##########
@@ -159,6 +168,7 @@ private StructType lazyPosDeleteSparkType() {
.withPartition(partition)
.equalityFieldIds(equalityFieldIds)
.withKeyMetadata(file.keyMetadata())
+ .withSortOrder(sortOrder)
Review comment:
Thank you for the review! Yes I wasn't sure when `sortOrder` will be
available from engine, and they are currently all null for now. I assumed that
this information could be available when engine constructs the appender factory
like `SparkAppenderFactory` since it seems that the factory will be created per
task level in Spark, so that `sortOrder` can be assigned based on individual
task. But since I don't know the details about each engine I'll revert the
changes to each appender factory for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
