jackye1995 commented on pull request #2214: URL: https://github.com/apache/iceberg/pull/2214#issuecomment-782256886
> If you were actually referring to newAppender, since the creation of ContentFile that stores sort order information is outside the responsibility of FileAppender, the caller of it that creates data/delete file is responsible for passing the sort order around. I think it's the same reason as why we created DataWriter. Yes I was referring to the appender. Thanks for the clarification. > I think the row level delete support is also in this style - SparkAppenderFactory constructor could take in row level delete related arguments, but SparkWrite and other spark code are not using such constructor yet. Okay I see, in that case this should be fine. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
