shardulm94 commented on pull request #2254: URL: https://github.com/apache/iceberg/pull/2254#issuecomment-782246914
The manifest and residual evaluator expect the following java types for each data type https://github.com/apache/iceberg/blob/efc461862fc93637fe4c0127d69bfb777c87766e/api/src/main/java/org/apache/iceberg/types/Type.java#L29 I think we will need to do something very similar to wrapping the record into an `InternalRecordWrapper` like here https://github.com/apache/iceberg/blob/efc461862fc93637fe4c0127d69bfb777c87766e/data/src/main/java/org/apache/iceberg/data/GenericReader.java#L86 That should handle conversion between types used by `iceberg-data` v/s the ones used by the evaluators. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
