marton-bod commented on a change in pull request #2254:
URL: https://github.com/apache/iceberg/pull/2254#discussion_r580080228
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java
##########
@@ -284,8 +285,9 @@ public void close() throws IOException {
boolean applyResidual =
!context.getConfiguration().getBoolean(InputFormatConfig.SKIP_RESIDUAL_FILTERING,
false);
if (applyResidual && residual != null && residual !=
Expressions.alwaysTrue()) {
+ InternalRecordWrapper wrapper = new
InternalRecordWrapper(readSchema.asStruct());
Review comment:
Can we add a comment here why this wrapper is needed? I think the class
name doesn't tell you much and it does not have javadoc either to explain its
purpose. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
