pvary commented on a change in pull request #2254:
URL: https://github.com/apache/iceberg/pull/2254#discussion_r582350864
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerLocalScan.java
##########
@@ -563,6 +566,61 @@ public void testStructOfStructsInTable() throws
IOException {
}
}
+ @Test
+ public void testDateQuery() throws IOException {
+ Schema dateSchema = new Schema(optional(1, "d_date",
Types.DateType.get()));
+
+ List<Record> records = TestHelper.RecordsBuilder.newInstance(dateSchema)
+ .add(LocalDate.of(2020, 1, 21))
+ .add(LocalDate.of(2020, 1, 24))
+ .build();
+
+ testTables.createTable(shell, "date_test", dateSchema, fileFormat,
records);
+
+ List<Object[]> result = shell.executeStatement("SELECT * from date_test
WHERE d_date='2020-01-21'");
+ Assert.assertEquals(1, result.size());
+ Assert.assertEquals("2020-01-21", result.get(0)[0]);
+
+ result = shell.executeStatement("SELECT * from date_test WHERE d_date in
('2020-01-21', '2020-01-22')");
+ Assert.assertEquals(1, result.size());
+ Assert.assertEquals("2020-01-21", result.get(0)[0]);
+
+ result = shell.executeStatement("SELECT * from date_test WHERE d_date >
'2020-01-21'");
+ Assert.assertEquals(1, result.size());
+ Assert.assertEquals("2020-01-24", result.get(0)[0]);
+
+ result = shell.executeStatement("SELECT * from date_test WHERE
d_date='2020-01-20'");
+ Assert.assertEquals(0, result.size());
+ }
+
+ @Test
+ public void testTimestampQuery() throws IOException {
Review comment:
The tests were running for me in CET TZ, but you have a point here.
Added a specific test case to test out the things with multiple TZs. Had to do
some magic to remove old default timezones from cached objects, but finally it
works.
Could you please check again?
Thanks,
Peter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
