aokolnychyi commented on a change in pull request #2255: URL: https://github.com/apache/iceberg/pull/2255#discussion_r582315919
########## File path: api/src/main/java/org/apache/iceberg/actions/SnapshotTable.java ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +import java.util.Map; + +/** + * An action that creates an independent snapshot of an existing table. + */ +public interface SnapshotTable extends Action<SnapshotTable.Result> { + /** + * Sets the table location. + * + * @param location a table location + * @return this for method chaining + */ + SnapshotTable withLocation(String location); + + /** + * Adds additional properties to the newly created Iceberg table. Any properties with + * the same key name will be overwritten. + * + * @param properties a map of properties to be included + * @return this for method chaining + */ + SnapshotTable withProperties(Map<String, String> properties); + + /** + * Adds an additional property to the newly created Iceberg table. Any properties + * with the same key name will be overwritten. + * + * @param key the key of the property to add + * @param value the value of the property to add + * @return this for method chaining + */ + SnapshotTable withProperty(String key, String value); Review comment: Replaced with `tableProperty`. ########## File path: api/src/main/java/org/apache/iceberg/actions/MigrateTable.java ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +import java.util.Map; + +/** + * An action that migrates an existing table to Iceberg. + */ +public interface MigrateTable extends Action<MigrateTable.Result> { + /** + * Adds additional properties to the newly created Iceberg table. Any properties with + * the same key name will be overwritten. + * + * @param properties a map of properties to be included + * @return this for method chaining + */ + MigrateTable withProperties(Map<String, String> properties); + + /** + * Adds an additional property to the newly created Iceberg table. Any properties + * with the same key name will be overwritten. + * + * @param key the key of the property to add + * @param value the value of the property to add + * @return this for method chaining + */ + MigrateTable withProperty(String key, String value); Review comment: Done. ########## File path: api/src/main/java/org/apache/iceberg/actions/SnapshotUpdate.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +import org.apache.iceberg.Snapshot; + +/** + * An action that produces snapshots. This interface contains common methods for all + * actions that create a new table {@link Snapshot}. Review comment: Done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
