aokolnychyi commented on pull request #2255: URL: https://github.com/apache/iceberg/pull/2255#issuecomment-785403354
I've addressed some of the comments. Still open questions: - Having `options` in the `Action` directly. That seems simpler than having `ConfigurableAction`. - Accepting Strings instead of Tables in all actions so that each action loads the table. My worry is that it will require a proper catalog config for resolution. I think most people will leverage SQL extensions for simple cases so it feels more flexible to pass the `Table` object. However, I agree it is not consistent with `snapshotTable` and `migrateTable`. - Shall we make action results closeable? Seems like that would really complicate the usage so maybe we can skip doing that unless needed by other query engines. - Using `with` prefix for some method names. I'd say let's not use it to be consistent. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
