rdblue commented on pull request #2255: URL: https://github.com/apache/iceberg/pull/2255#issuecomment-786312470
> Having options in the Action directly. That seems simpler than having ConfigurableAction. +1 > Accepting Strings instead of Tables in all actions so that each action loads the table. I actually like that some accept a `Table`. I'm trying to think of a better way to structure the ones that take strings. I agree with the idea that it is easier to use that way, but the problem is that we need a way to parse the string into an identifier and to load a catalog. Maybe we should have a version that accepts a catalog and an identifier? I'm not sure what to do here. > Shall we make action results closeable? Let's skip it for now if we don't need it. > Using with prefix for some method names. I'd say let's not use it to be consistent. +1 for fewer words. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
