rdblue commented on a change in pull request #2276:
URL: https://github.com/apache/iceberg/pull/2276#discussion_r588807652
##########
File path: core/src/main/java/org/apache/iceberg/DataFilesTable.java
##########
@@ -102,8 +102,8 @@ protected TableScan newRefinedScan(TableOperations ops,
Table table, Schema sche
}
@Override
- protected long targetSplitSize(TableOperations ops) {
- return ops.current().propertyAsLong(
+ public long targetSplitSize() {
+ return tableOps().current().propertyAsLong(
Review comment:
No, my concern is that if `ops` is available as an instance field it is
probably better to access it that way rather than through a method call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
