sunchao commented on a change in pull request #2276:
URL: https://github.com/apache/iceberg/pull/2276#discussion_r588807898



##########
File path: api/src/main/java/org/apache/iceberg/FileScanTask.java
##########
@@ -47,6 +47,13 @@
    */
   PartitionSpec spec();
 
+  /**
+   * The partition data for the file of this task.

Review comment:
       This makes sense. It requires Spark (or other engines) to pushdown the 
info to data sources like Iceberg though, and I'm not sure how complex that 
would be. My current approach is to do this in Spark, by pushing down the 
join/aggregate keys to scan node where it combines the input partitions 
accordingly. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to