openinx commented on a change in pull request #2276:
URL: https://github.com/apache/iceberg/pull/2276#discussion_r590976700
##########
File path: core/src/main/java/org/apache/iceberg/util/TableScanUtil.java
##########
@@ -48,13 +58,42 @@ public static boolean hasDeletes(FileScanTask task) {
}
public static CloseableIterable<CombinedScanTask>
planTasks(CloseableIterable<FileScanTask> splitFiles,
- long splitSize,
int lookback, long openFileCost) {
+ long splitSize, int lookback, long openFileCost, PartitionSpec spec) {
Review comment:
I don't think there's meaningful to change this method to accept an
extra `PartitionSpec` argument, because we will set the
`preservedPartitionIndices` to be `null` in the real implementation. Finally,
we won't do any partition GROUP BY in the real path.
I think we could keep the method definition just as it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
