edgarRd commented on pull request #2329:
URL: https://github.com/apache/iceberg/pull/2329#issuecomment-799740810


   Thanks for working on this. I think this is great to have the stats in the 
Hive table metadata. 
   
   However, I think it'd still be good to implement `InputEstimator` in the 
`HiveIcebergStorageHandler` to provide the right estimation on the scan using 
the filter during a join plan. It's a bit tricky in Iceberg since we'd need to 
compute the split tasks again or cache them. I guess initially computing them 
again (if we can reuse the code) would be okay to avoid caching.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to