pvary commented on pull request #2329: URL: https://github.com/apache/iceberg/pull/2329#issuecomment-800173681
>I think it'd still be good to implement `InputEstimator` in the `HiveIcebergStorageHandler` to provide the right estimation on the scan using the filter during a join plan. It's a bit tricky [..] I have checked the Hive code and only `InputEstimatorTestClass` implements the `InputEstimator`. Also checked the usages of `Estimation` object. Only `getTotalLength` is used. Once for determining if we can use fetch task instead of spawning an MR/Tez job, and then for generating `ContentSummary.length`. This later one is used several places, so it can be useful but we definitely need specific use-cases to check how much effort should we put into calculating the value ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
