marton-bod commented on a change in pull request #2329:
URL: https://github.com/apache/iceberg/pull/2329#discussion_r595123298
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -296,6 +302,11 @@ private void setHmsTableParameters(String
newMetadataLocation, Table tbl, Map<St
parameters.remove(hive_metastoreConstants.META_TABLE_STORAGE);
}
+ // Set the basic statistics
+ parameters.put(StatsSetupConst.NUM_FILES,
summary.getOrDefault(SnapshotSummary.TOTAL_DATA_FILES_PROP, "0"));
+ parameters.put(StatsSetupConst.ROW_COUNT,
summary.getOrDefault(SnapshotSummary.TOTAL_RECORDS_PROP, "0"));
+ parameters.put(StatsSetupConst.TOTAL_SIZE,
summary.getOrDefault(SnapshotSummary.TOTAL_FILE_SIZE_PROP, "0"));
Review comment:
When creating a table, `metadata.currentSnapshot()` is null, therefore
we won't have a summary and will create an empty map for it. I think @rdblue is
right that we should only update the HMS values if they're actually present in
the summary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
