aokolnychyi commented on a change in pull request #2214:
URL: https://github.com/apache/iceberg/pull/2214#discussion_r599173752
##########
File path:
core/src/main/java/org/apache/iceberg/deletes/EqualityDeleteWriter.java
##########
@@ -39,17 +40,25 @@
private final StructLike partition;
private final ByteBuffer keyMetadata;
private final int[] equalityFieldIds;
+ private final SortOrder sortOrder;
private DeleteFile deleteFile = null;
public EqualityDeleteWriter(FileAppender<T> appender, FileFormat format,
String location,
PartitionSpec spec, StructLike partition,
EncryptionKeyMetadata keyMetadata,
int... equalityFieldIds) {
+ this(appender, format, location, spec, partition, keyMetadata, null,
equalityFieldIds);
+ }
+
+ public EqualityDeleteWriter(FileAppender<T> appender, FileFormat format,
String location,
Review comment:
I'd be fine keeping if there is a valid use case but I'd hope folks use
a higher-level API for writing deletes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
