yyanyy commented on a change in pull request #2214:
URL: https://github.com/apache/iceberg/pull/2214#discussion_r599135897
##########
File path:
core/src/main/java/org/apache/iceberg/deletes/EqualityDeleteWriter.java
##########
@@ -39,17 +40,25 @@
private final StructLike partition;
private final ByteBuffer keyMetadata;
private final int[] equalityFieldIds;
+ private final SortOrder sortOrder;
private DeleteFile deleteFile = null;
public EqualityDeleteWriter(FileAppender<T> appender, FileFormat format,
String location,
PartitionSpec spec, StructLike partition,
EncryptionKeyMetadata keyMetadata,
int... equalityFieldIds) {
+ this(appender, format, location, spec, partition, keyMetadata, null,
equalityFieldIds);
+ }
+
+ public EqualityDeleteWriter(FileAppender<T> appender, FileFormat format,
String location,
Review comment:
Good point, I think we can remove the old constructor in this case, as I
think this class is for supporting V2 table and thus shouldn't have a lot of
dependencies outside of the library packages for production usage, so we should
probably be able to do it now. I will update the PR to update the existing
constructor unless people have further comments on this thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
