yyanyy commented on a change in pull request #2214:
URL: https://github.com/apache/iceberg/pull/2214#discussion_r599134332
##########
File path: core/src/main/java/org/apache/iceberg/avro/Avro.java
##########
@@ -284,6 +286,11 @@ public DeleteWriteBuilder equalityFieldIds(int...
fieldIds) {
return this;
}
+ public DeleteWriteBuilder withSortOrder(SortOrder newSortOrder) {
Review comment:
Thank you for the review! I think setting an order for regular data
files is covered by changes in `DataWriter` file, as in Avro/Parquet/ORC files
what `WriteBuilder` builds is actually an `FileAppender` that doesn't track
file properties, and it's the `DataWriter` which wraps around this file
appender that actually populates these information into a `DataFile` when it
closes. I do think this seems a bit confusing and we may want to refactor these
classes a bit to make delete and data writers to be constructed in a more
similar way.
Regarding ORC - the reason for me to not change ORC is that ORC seems to not
support delete writer. I wasn't sure if it was intentional, or just because no
one had time to do it. If the latter is the case, I'm happy to create a
separate PR to add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
