rymurr commented on a change in pull request #2674:
URL: https://github.com/apache/iceberg/pull/2674#discussion_r645433475
##########
File path: spark2/src/test/java/org/apache/iceberg/spark/source/TestCatalog.java
##########
@@ -95,7 +95,7 @@ public void initialize(String name, Map<String, String>
properties) {
String uri = properties.get(CatalogProperties.URI);
warehouse = properties.get("warehouse");
Preconditions.checkArgument(uri != null, "A uri parameter must be set");
- Preconditions.checkArgument(uri.contains("thrift"), "A ur parameter must
be valid");
+ Preconditions.checkArgument(uri.contains("thrift"), "A uri parameter must
be valid");
Review comment:
> How about `Cannot initialize TestCatalog, the catalog's metastore
connection uri must use thrift as the scheme.`?
agreed, the fix is probably redundant for the tests
> I'm tempted to update all of these Preconditions while I'm here,
Love the idea, thanks for taking that on. makes a massive difference to the
community imho. I always start w/ reading the tests :-)
##########
File path: spark2/src/test/java/org/apache/iceberg/spark/source/TestCatalog.java
##########
@@ -95,7 +95,7 @@ public void initialize(String name, Map<String, String>
properties) {
String uri = properties.get(CatalogProperties.URI);
warehouse = properties.get("warehouse");
Preconditions.checkArgument(uri != null, "A uri parameter must be set");
- Preconditions.checkArgument(uri.contains("thrift"), "A ur parameter must
be valid");
+ Preconditions.checkArgument(uri.contains("thrift"), "A uri parameter must
be valid");
Review comment:
> How about `Cannot initialize TestCatalog, the catalog's metastore
connection uri must use thrift as the scheme.`?
agreed, the fix is probably redundant for the tests
> I'm tempted to update all of these Preconditions while I'm here,
Love the idea, thanks for taking that on. makes a massive difference to the
community imho. I always start w/ reading the tests :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
