kbendick commented on a change in pull request #2674:
URL: https://github.com/apache/iceberg/pull/2674#discussion_r645437726
##########
File path: spark2/src/test/java/org/apache/iceberg/spark/source/TestCatalog.java
##########
@@ -95,7 +95,7 @@ public void initialize(String name, Map<String, String>
properties) {
String uri = properties.get(CatalogProperties.URI);
warehouse = properties.get("warehouse");
Preconditions.checkArgument(uri != null, "A uri parameter must be set");
- Preconditions.checkArgument(uri.contains("thrift"), "A ur parameter must
be valid");
+ Preconditions.checkArgument(uri.contains("thrift"), "A uri parameter must
be valid");
Review comment:
Always happy to help make the project more friendly to newcomers 👍.
I'll update the Preconditions in the morning (it's admittedly really later
where I am).
I've got some other, much larger and long overdue community help stuff lined
up too (a docker-compose environment) that I am hoping to push next week. I'd
love to get it working first for the basics (spark with a consistent metastore
- currently barebones Hive) and then add Nessie to it as well 🙂. I'm currently
in the process of removing the internal bits and then deciding on what is too
much, but will probably just start small and iterate. I'll tag you there and
might reach out to ask for your opinion as well if you don't mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
