kbendick commented on a change in pull request #2674:
URL: https://github.com/apache/iceberg/pull/2674#discussion_r645431837
##########
File path: spark2/src/test/java/org/apache/iceberg/spark/source/TestCatalog.java
##########
@@ -95,7 +95,7 @@ public void initialize(String name, Map<String, String>
properties) {
String uri = properties.get(CatalogProperties.URI);
warehouse = properties.get("warehouse");
Preconditions.checkArgument(uri != null, "A uri parameter must be set");
- Preconditions.checkArgument(uri.contains("thrift"), "A ur parameter must
be valid");
+ Preconditions.checkArgument(uri.contains("thrift"), "A uri parameter must
be valid");
Review comment:
Strongly agree, @rymurr.
How about `Cannot initialize TestCatalog, the catalog's metastore connection
uri must use thrift as the scheme.`?
The optional fix, in theory, would be something along the lines of `Please
update the metastore URI configuration on the SparkContext to a valid Hive
metastore thrift URI of the form of 'thrift://host:port', via the key
'spark.sql.catalog.${catalog_name}.uri'`, though in this case, I think that the
optional how to fix is likely unnecessary (as it's just a mock, though that is
how one would resolve that issue).
What do you think? I'm tempted to update all of these Preconditions while
I'm here, as I feel like people often look at the tests to learn how to do
things (even if they could realistically get that information from the docs). 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
