jackye1995 commented on a change in pull request #2675:
URL: https://github.com/apache/iceberg/pull/2675#discussion_r645811936
##########
File path: core/src/main/java/org/apache/iceberg/GenericManifestFile.java
##########
@@ -399,6 +415,7 @@ public String toString() {
.add("deleted_data_files_count", deletedFilesCount)
.add("deleted_rows_count", deletedRowsCount)
.add("partitions", partitions)
+ .add("key_metadata", keyMetadata == null ? "null" : "(redacted)")
Review comment:
I would actually be more against using this approach to support redact,
for 2 reasons:
1. this is only for `toString`. If you really want to see the details of the
key metadata you can read through the manifest table, and that should show the
information fully if you can decrypt an encrypted manifest list. I think that
provides better access control. Changing `toString` feels to me like opening a
backdoor.
2. if we can encrypt a manifest, we should be able to support redact
configuration natively through encryption manager as a part of data masking.
When we can do that, you don't need a forked version to use a custom static
method for this purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
