RussellSpitzer commented on a change in pull request #2675:
URL: https://github.com/apache/iceberg/pull/2675#discussion_r650073436
##########
File path: core/src/main/java/org/apache/iceberg/GenericManifestFile.java
##########
@@ -124,6 +128,7 @@ public GenericManifestFile(String path, long length, int
specId, ManifestContent
this.deletedRowsCount = deletedRowsCount;
this.partitions = partitions == null ? null : partitions.toArray(new
PartitionFieldSummary[0]);
this.fromProjectionPos = null;
+ this.keyMetadata = ByteBuffers.toByteArray(keyMetadata);
Review comment:
Do we need a null guard here?
##########
File path: core/src/main/java/org/apache/iceberg/GenericManifestFile.java
##########
@@ -399,6 +415,7 @@ public String toString() {
.add("deleted_data_files_count", deletedFilesCount)
.add("deleted_rows_count", deletedRowsCount)
.add("partitions", partitions)
+ .add("key_metadata", keyMetadata == null ? "null" : "(redacted)")
Review comment:
So maybe we should just drop this from toString? I'm fine with that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
