jackye1995 commented on a change in pull request #2675:
URL: https://github.com/apache/iceberg/pull/2675#discussion_r651112423



##########
File path: core/src/main/java/org/apache/iceberg/GenericManifestFile.java
##########
@@ -124,6 +128,7 @@ public GenericManifestFile(String path, long length, int 
specId, ManifestContent
     this.deletedRowsCount = deletedRowsCount;
     this.partitions = partitions == null ? null : partitions.toArray(new 
PartitionFieldSummary[0]);
     this.fromProjectionPos = null;
+    this.keyMetadata = ByteBuffers.toByteArray(keyMetadata);

Review comment:
       There is already a null guard in `ByteBuffers`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to