RussellSpitzer commented on a change in pull request #2617:
URL: https://github.com/apache/iceberg/pull/2617#discussion_r648658993
##########
File path: core/src/main/java/org/apache/iceberg/ManifestEntriesTable.java
##########
@@ -69,18 +69,35 @@ MetadataTableType metadataTableType() {
private static class EntriesTableScan extends BaseTableScan {
- EntriesTableScan(TableOperations ops, Table table, Schema schema) {
+ private final String scannedTableName;
+
+ EntriesTableScan(TableOperations ops, Table table, Schema schema, String
scannedTableName) {
super(ops, table, schema);
+ this.scannedTableName = scannedTableName;
}
- private EntriesTableScan(TableOperations ops, Table table, Schema schema,
TableScanContext context) {
+ private EntriesTableScan(TableOperations ops, Table table, Schema schema,
String scannedTableName,
+ TableScanContext context) {
super(ops, table, schema, context);
+ this.scannedTableName = scannedTableName;
+ }
+
+ @Override
+ public TableScan appendsBetween(long fromSnapshotId, long toSnapshotId) {
+ throw new UnsupportedOperationException(
+ String.format("Incremental scan is not supported for metadata table
%s", scannedTableName));
+ }
+
+ @Override
+ public TableScan appendsAfter(long fromSnapshotId) {
+ throw new UnsupportedOperationException(
+ String.format("Incremental scan is not supported for metadata table
%s", scannedTableName));
Review comment:
Could we switch the constructor change to a abstract method? Then every
subclass could just add in their own table type something like?
String.format("Incremental scan is not supported for $tableType scan of
table $table.name")
Where tableType is defined by subclasses and table is just the table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
