RussellSpitzer commented on a change in pull request #2617:
URL: https://github.com/apache/iceberg/pull/2617#discussion_r650303265
##########
File path: core/src/main/java/org/apache/iceberg/ManifestEntriesTable.java
##########
@@ -69,18 +69,35 @@ MetadataTableType metadataTableType() {
private static class EntriesTableScan extends BaseTableScan {
- EntriesTableScan(TableOperations ops, Table table, Schema schema) {
+ private final String scannedTableName;
+
+ EntriesTableScan(TableOperations ops, Table table, Schema schema, String
scannedTableName) {
super(ops, table, schema);
+ this.scannedTableName = scannedTableName;
}
- private EntriesTableScan(TableOperations ops, Table table, Schema schema,
TableScanContext context) {
+ private EntriesTableScan(TableOperations ops, Table table, Schema schema,
String scannedTableName,
+ TableScanContext context) {
super(ops, table, schema, context);
+ this.scannedTableName = scannedTableName;
+ }
+
+ @Override
+ public TableScan appendsBetween(long fromSnapshotId, long toSnapshotId) {
+ throw new UnsupportedOperationException(
+ String.format("Incremental scan is not supported for metadata table
%s", scannedTableName));
+ }
+
+ @Override
+ public TableScan appendsAfter(long fromSnapshotId) {
+ throw new UnsupportedOperationException(
+ String.format("Incremental scan is not supported for metadata table
%s", scannedTableName));
Review comment:
Yep that's what I was suggesting. If we really wanted it you could just
do table
History scan of table $tableName.$metadataIdentifier (which would only be
wrong for hadoop tables)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
