jackye1995 commented on a change in pull request #2560:
URL: https://github.com/apache/iceberg/pull/2560#discussion_r653859623
##########
File path:
spark3-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4
##########
@@ -71,6 +71,8 @@ statement
| ALTER TABLE multipartIdentifier DROP PARTITION FIELD transform
#dropPartitionField
| ALTER TABLE multipartIdentifier REPLACE PARTITION FIELD transform WITH
transform (AS name=identifier)? #replacePartitionField
| ALTER TABLE multipartIdentifier WRITE writeSpec
#setWriteDistributionAndOrdering
+ | ALTER TABLE table=multipartIdentifier SET IDENTIFIER_KW FIELDS '('
fields+=multipartIdentifier (',' fields+=multipartIdentifier)* ')'
#setIdentifierFields
Review comment:
> I would make the parens optional
Do you mean to also not have parens optional when there are multiple fields,
like:
```
SET IDENTIFIER FIELDS first_name, last_name
```
Or is it only for the case when there is 1 field?
##########
File path:
spark3-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4
##########
@@ -71,6 +71,8 @@ statement
| ALTER TABLE multipartIdentifier DROP PARTITION FIELD transform
#dropPartitionField
| ALTER TABLE multipartIdentifier REPLACE PARTITION FIELD transform WITH
transform (AS name=identifier)? #replacePartitionField
| ALTER TABLE multipartIdentifier WRITE writeSpec
#setWriteDistributionAndOrdering
+ | ALTER TABLE table=multipartIdentifier SET IDENTIFIER_KW FIELDS '('
fields+=multipartIdentifier (',' fields+=multipartIdentifier)* ')'
#setIdentifierFields
Review comment:
Okay that makes sense. I will update with all the other comments, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
