jackye1995 commented on pull request #2560: URL: https://github.com/apache/iceberg/pull/2560#issuecomment-865699352
@rdblue sorry I was stuck with some internal work and did not get time to update this. the latest code addressed most of the comments. I have been thinking about the syntax over the last few days, I think I was very biased with the Hive DDL syntax, but as you pointed out, if we prefer the other way, it might be better to instead use a syntax like: ```sql ALTER TABLE table WRITE IDENTIFIED BY first_name,last_name; ``` And we don't support any other syntax like add and drop. This avoids the confusion and it should be clear that we are replacing all the identifier fields. It is closer to the existing syntax of sort order, plus it does not need parentheses. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
