rdblue commented on a change in pull request #2733:
URL: https://github.com/apache/iceberg/pull/2733#discussion_r658342847
##########
File path:
nessie/src/test/java/org/apache/iceberg/nessie/TestBranchVisibility.java
##########
@@ -122,10 +119,11 @@ private void updateSchema(NessieCatalog catalog,
TableIdentifier identifier) {
catalog.loadTable(identifier).updateSchema().addColumn("id" +
schemaCounter++, Types.LongType.get()).commit();
}
- private void testCatalogEquality(NessieCatalog catalog,
- NessieCatalog compareCatalog,
- boolean table1Equal,
- boolean table2Equal) {
+ private void testCatalogEquality(
+ NessieCatalog catalog,
+ NessieCatalog compareCatalog,
+ boolean table1Equal,
+ boolean table2Equal) {
Review comment:
I think the project prefers keeping multiple arguments on a line and
wrapping at the same depth as the starting argument. So there are multiple
options:
```java
private void testCatalogEquality(NessieCatalog catalog, NessieCatalog
compareCatalog,
boolean table1Equal, boolean table2Equal)
{
```
or,
```java
private void testCatalogEquality(
NessieCatalog catalog, NessieCatalog compareCatalog, boolean
table1Equal, boolean table2Equal) {
```
I think one thing that we don't usually want is one argument per line since
you end up having really long argument lists. That's a problem in both cases,
though.
Is this something we can fix in the style config that you've applied?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
