nastra commented on a change in pull request #2733:
URL: https://github.com/apache/iceberg/pull/2733#discussion_r663018619
##########
File path:
nessie/src/test/java/org/apache/iceberg/nessie/TestBranchVisibility.java
##########
@@ -122,10 +119,11 @@ private void updateSchema(NessieCatalog catalog,
TableIdentifier identifier) {
catalog.loadTable(identifier).updateSchema().addColumn("id" +
schemaCounter++, Types.LongType.get()).commit();
}
- private void testCatalogEquality(NessieCatalog catalog,
- NessieCatalog compareCatalog,
- boolean table1Equal,
- boolean table2Equal) {
+ private void testCatalogEquality(
+ NessieCatalog catalog,
+ NessieCatalog compareCatalog,
+ boolean table1Equal,
+ boolean table2Equal) {
Review comment:
seems like the formatter defaults to putting every single argument into
a new line when **all** of them don't fit into the same line. However, if one
does split up the args manually up and format the code, then the below format
is valid as well. It's just that this preferrable format isn't automatically
the first choice of the formatter and I'm not sure we can do anything about it
atm.
```
private void testCatalogEquality(
NessieCatalog catalog, NessieCatalog compareCatalog, boolean
table1Equal, boolean table2Equal) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
