nastra commented on a change in pull request #2733:
URL: https://github.com/apache/iceberg/pull/2733#discussion_r658508437
##########
File path:
nessie/src/test/java/org/apache/iceberg/nessie/TestBranchVisibility.java
##########
@@ -122,10 +119,11 @@ private void updateSchema(NessieCatalog catalog,
TableIdentifier identifier) {
catalog.loadTable(identifier).updateSchema().addColumn("id" +
schemaCounter++, Types.LongType.get()).commit();
}
- private void testCatalogEquality(NessieCatalog catalog,
- NessieCatalog compareCatalog,
- boolean table1Equal,
- boolean table2Equal) {
+ private void testCatalogEquality(
+ NessieCatalog catalog,
+ NessieCatalog compareCatalog,
+ boolean table1Equal,
+ boolean table2Equal) {
Review comment:
I don't prefer having each argument on a separate line either, but that
is the result of formatting the code with `intellij-java-palantir-style.xml`.
As mentioned on #2732 it would be ideal to enforce such style rules so that
unformatted code doesn't make it into the project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
