RussellSpitzer commented on a change in pull request #2749:
URL: https://github.com/apache/iceberg/pull/2749#discussion_r660212216
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/BaseVectorizedParquetValuesReader.java
##########
@@ -80,17 +80,23 @@ public BaseVectorizedParquetValuesReader(int maxDefLevel,
boolean setValidityVec
this.setArrowValidityVector = setValidityVector;
}
- public BaseVectorizedParquetValuesReader(
- int bitWidth,
- int maxDefLevel,
- boolean setValidityVector) {
+ public BaseVectorizedParquetValuesReader(int bitWidth, int maxDefLevel,
boolean setValidityVector) {
this.fixedWidth = true;
this.readLength = bitWidth != 0;
this.maxDefLevel = maxDefLevel;
this.setArrowValidityVector = setValidityVector;
init(bitWidth);
}
+ public BaseVectorizedParquetValuesReader(int bitWidth, int maxDefLevel,
boolean readLength,
+ boolean setValidityVector) {
+ this.fixedWidth = true;
+ this.readLength = readLength;
Review comment:
It seems a little strange to me that we have this constructor which we
only use when readLength is false. Perhaps we should swap the original
constructor's code to call this constructor?
```java
public BaseVectorizedParquetValuesReader(int bitWidth, int maxDefLevel,
boolean setValidityVector) {
this(bitWidth, maxDefLevel, bitWidth != 0, setValidityVector)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
