RussellSpitzer commented on a change in pull request #2749:
URL: https://github.com/apache/iceberg/pull/2749#discussion_r660213079
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/BasePageIterator.java
##########
@@ -77,7 +77,8 @@ protected void reset() {
protected abstract void initDefinitionLevelsReader(DataPageV1 dataPageV1,
ColumnDescriptor descriptor,
ByteBufferInputStream in,
int count) throws IOException;
- protected abstract void initDefinitionLevelsReader(DataPageV2 dataPageV2,
ColumnDescriptor descriptor);
+ protected abstract void initDefinitionLevelsReader(DataPageV2 dataPageV2,
ColumnDescriptor descriptor)
+ throws IOException;
Review comment:
I didn't see where the IOException can get thrown, is this just to match
the V1 reader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
