RussellSpitzer commented on a change in pull request #2749:
URL: https://github.com/apache/iceberg/pull/2749#discussion_r660573432
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedPageIterator.java
##########
@@ -512,6 +512,9 @@ protected void initDataReader(Encoding dataEncoding,
ByteBufferInputStream in, i
throw new ParquetDecodingException("could not read page in col " +
desc, e);
}
} else {
+ if (dataEncoding != Encoding.PLAIN) {
+ throw new UnsupportedOperationException("Unsupported encoding: " +
dataEncoding);
Review comment:
Sounds good to me, I do know most of the time we have errors styled as
"Cannot X " but I think your content suggestion for the error message is solid.
I would just add that so it fits with the other messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
