rdblue commented on a change in pull request #1508:
URL: https://github.com/apache/iceberg/pull/1508#discussion_r698062074
##########
File path: core/src/main/java/org/apache/iceberg/BaseTable.java
##########
@@ -74,6 +75,57 @@ public Schema schema() {
return ops.current().schemasById();
}
+ /**
+ * Return the {@link Schema schema} for this table at the time of the
snapshot
+ * specified by the snapshotId.
+ *
+ * @return the schema
+ */
+ public Schema schemaForSnapshot(long snapshotId) {
Review comment:
Now that snapshots can report the schema that was current when the
snapshot was created, I think that the first PR should focus on using that
schema and not recovering schemas from old metadata files. We may want to add
this later, but it over-complicates getting the initial feature done.
I think that these helpers should be moved to a separate PR. Then this won't
need to modify `BaseTable` at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
