rdblue commented on a change in pull request #1508:
URL: https://github.com/apache/iceberg/pull/1508#discussion_r698062246
##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkUtil.java
##########
@@ -85,17 +85,17 @@ public static void
validatePartitionTransforms(PartitionSpec spec) {
if (nameParts.size() == 1) {
// Only a single element, use current catalog and namespace
- return Pair.of(currentCatalog, identiferProvider.apply(currentNamespace,
name));
+ return Pair.of(currentCatalog,
identifierProvider.apply(currentNamespace, name));
} else {
C catalog = catalogProvider.apply(nameParts.get(0));
if (catalog == null) {
// The first element was not a valid catalog, treat it like part of
the namespace
String[] namespace = nameParts.subList(0,
lastElementIndex).toArray(new String[0]);
- return Pair.of(currentCatalog, identiferProvider.apply(namespace,
name));
+ return Pair.of(currentCatalog, identifierProvider.apply(namespace,
name));
} else {
// Assume the first element is a valid catalog
String[] namespace = nameParts.subList(1,
lastElementIndex).toArray(new String[0]);
- return Pair.of(catalog, identiferProvider.apply(namespace, name));
+ return Pair.of(catalog, identifierProvider.apply(namespace, name));
Review comment:
This looks like an unrelated change. Can you move it to a separate PR?
We want to keep this one small since it's quite large already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]