rdblue commented on a change in pull request #1508:
URL: https://github.com/apache/iceberg/pull/1508#discussion_r698064639
##########
File path: spark3/src/main/java/org/apache/iceberg/spark/Spark3Util.java
##########
@@ -742,16 +743,20 @@ private static String
sqlString(org.apache.iceberg.expressions.Literal<?> lit) {
return null;
}
+ private static List<String> getMultipartIdentifier(SparkSession spark,
String name) throws ParseException {
Review comment:
Nit: use of `get` in a method name signals either that there is a more
descriptive verb (like "create") or that "get" can simply be removed (as in the
case of a getter).
This should probably be `parseMultipartIdentifier`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
