openinx commented on a change in pull request #2905:
URL: https://github.com/apache/iceberg/pull/2905#discussion_r700719175
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/source/RowDataFileReader.java
##########
@@ -47,51 +45,51 @@
import org.apache.iceberg.types.TypeUtil;
import org.apache.iceberg.util.PartitionUtil;
-class RowDataIterator extends DataIterator<RowData> {
+public class RowDataFileReader implements FileReader<RowData> {
Review comment:
Nit: Better to add a comment indicating that the RowDataFileReader is
designed for scanning rows from FileScanTask. Because as a reviewer, I cannot
see the meaning directly from the class naming ( I think it's a historical
issue in the initial review :-) )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
