wypoon commented on a change in pull request #1508: URL: https://github.com/apache/iceberg/pull/1508#discussion_r702207285
########## File path: spark3/src/main/java/org/apache/iceberg/spark/SnapshotAwareIdentifier.java ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.spark; + +import org.apache.spark.sql.connector.catalog.Identifier; + +/** + * An org.apache.spark.sql.connector.catalog.Identifier that allows + * org.apache.spark.sql.connector.catalog.TableCatalog#loadTable(Identifier) + * implemented by SparkCatalog to load a SparkTable corresponding to the snapshot + * given by id or timestamp, were either to be specified in options passed to the + * DataFrameReader. + */ +public interface SnapshotAwareIdentifier extends Identifier { + + Long snapshotId(); + + Long asOfTimestamp(); Review comment: The problem is that we need the `Table` in order to resolve the timestamp to a snapshot, and we need the identifier in order to load the `Table`. (Once the `Table` is loaded, we don't have an opportunity to set the timestamp, hence the need for `SnapshotAwareIdentifier`.) That is why I put the snapshot id and timestamp (if either (or both) appear) in the identifier, and deal with resolving to a snapshot later. Incidentally, I raised https://github.com/apache/iceberg/issues/3070 in case both snapshot id and timestamp are specified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
