[GitHub] [iceberg] wypoon commented on a change in pull request #1508: Use schema at the time of the snapshot when reading a snapshot.

[GitBox]

wypoon commented on a change in pull request #1508:
URL: https://github.com/apache/iceberg/pull/1508#discussion_r703124390



##########
File path: spark3/src/main/java/org/apache/iceberg/spark/Spark3Util.java
##########
@@ -767,19 +772,46 @@ public static CatalogAndIdentifier 
catalogAndIdentifier(String description, Spar
     }
   }
 
+  public static CatalogAndIdentifier catalogAndIdentifier(String description, 
SparkSession spark, String name,

Review comment:
       I tried leaving the `catalogAndIdentifier` methods in `Spark3Util` 
unchanged, and adding the snapshot id and timestamp to the Identifier in 
(spark3) `IcebergSource#catalogAndIdentifier` after calling 
`Spark3Util.catalogAndIdentifier`, but I must have missed something because the 
unit tests I added then failed. So I reverted that experiment. This 
implementation may be slightly more complicated but I know that it works.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org