[GitHub] [iceberg] wypoon commented on a change in pull request #1508: Use schema at the time of the snapshot when reading a snapshot.

[GitBox]

wypoon commented on a change in pull request #1508:
URL: https://github.com/apache/iceberg/pull/1508#discussion_r703926112



##########
File path: spark3/src/main/java/org/apache/iceberg/spark/Spark3Util.java
##########
@@ -767,19 +772,46 @@ public static CatalogAndIdentifier 
catalogAndIdentifier(String description, Spar
     }
   }
 
+  public static CatalogAndIdentifier catalogAndIdentifier(String description, 
SparkSession spark, String name,

Review comment:
       I figured out what I missed the first time around. I now add no new 
methods to `Spark3Util` and use existing `Spark3Util.catalogAndIdentifier` 
methods to obtain a `CatalogAndIdentifier`, and then swap out the `Identifier` 
for a snapshot-aware one.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org