flyrain commented on a change in pull request #3094:
URL: https://github.com/apache/iceberg/pull/3094#discussion_r707680350
##########
File path: core/src/main/java/org/apache/iceberg/LocationProviders.java
##########
@@ -99,8 +98,8 @@ public String newDataLocation(String filename) {
private final String context;
ObjectStoreLocationProvider(String tableLocation, Map<String, String>
properties) {
- this.storageLocation =
stripTrailingSlash(properties.getOrDefault(OBJECT_STORE_PATH,
- defaultDataLocation(tableLocation, properties)));
+ this.storageLocation =
+ stripTrailingSlash(dataLocation(properties, tableLocation,
TableProperties.OBJECT_STORE_PATH));
Review comment:
That's my original logic. I made the change per Ryan's comments
https://github.com/apache/iceberg/pull/3094#discussion_r705800767, which makes
sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
