jackye1995 commented on a change in pull request #3094:
URL: https://github.com/apache/iceberg/pull/3094#discussion_r708871961
##########
File path: core/src/main/java/org/apache/iceberg/LocationProviders.java
##########
@@ -68,16 +69,12 @@ public static LocationProvider locationsFor(String
location, Map<String, String>
}
}
- private static String defaultDataLocation(String tableLocation, Map<String,
String> properties) {
- return
properties.getOrDefault(TableProperties.WRITE_FOLDER_STORAGE_LOCATION,
- String.format("%s/data", tableLocation));
- }
-
static class DefaultLocationProvider implements LocationProvider {
private final String dataLocation;
DefaultLocationProvider(String tableLocation, Map<String, String>
properties) {
- this.dataLocation =
stripTrailingSlash(defaultDataLocation(tableLocation, properties));
+ this.dataLocation =
+ stripTrailingSlash(dataLocation(properties, tableLocation, false));
Review comment:
nit: is this newline needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
