jackye1995 commented on a change in pull request #3094:
URL: https://github.com/apache/iceberg/pull/3094#discussion_r708876536
##########
File path: core/src/main/java/org/apache/iceberg/LocationProviders.java
##########
@@ -141,4 +138,34 @@ private static String stripTrailingSlash(String path) {
}
return result;
}
+
+ private static String dataLocation(Map<String, String> properties, String
tableLocation, boolean isObjectStore) {
+ String dataLocation = properties.get(TableProperties.WRITE_DATA_LOCATION);
+ if (dataLocation == null) {
+ String deprecatedProperty = null;
Review comment:
I think we can use `String deprecatedProperty = isObjectStorage ?
TableProperties.OBJECT_STORE_PATH :
TableProperties.WRITE_FOLDER_STORAGE_LOCATION`, then `deprecatedProperty` is
always not null, and you don't need to do null check for the warning, and we
can avoid having that warning helper method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
