Flyangz commented on a change in pull request #3116:
URL: https://github.com/apache/iceberg/pull/3116#discussion_r715990954
##########
File path:
flink/src/main/resources/META-INF/services/org.apache.flink.table.factories.Factory
##########
@@ -13,4 +13,5 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-org.apache.iceberg.flink.FlinkDynamicTableFactory
\ No newline at end of file
+org.apache.iceberg.flink.FlinkDynamicTableFactory
+org.apache.iceberg.flink.FlinkCatalogFactory
Review comment:
If we only support 1.13, then is ok to remove it. But if we want to be
compatible with 1.12, `FlinkCatalogFactory` need to be treated as
`TableFactory` because `Context` class is missing in 1.12 and without
implementing `createCatalog(Context context)` will throw exception when we
place `FlinkCatalogFactory` in [
org.apache.flink.table.factories.Factory](https://github.com/apache/iceberg/blob/master/flink/src/main/resources/META-INF/services/org.apache.flink.table.factories.Factory)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
