openinx commented on a change in pull request #3116:
URL: https://github.com/apache/iceberg/pull/3116#discussion_r713702839
##########
File path: flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java
##########
@@ -101,11 +108,28 @@ static CatalogLoader createCatalogLoader(String name,
Map<String, String> proper
}
}
+ @Override
+ public String factoryIdentifier() {
+ return IDENTIFIER;
+ }
+
+ @Override
+ public Set<ConfigOption<?>> requiredOptions() {
+ return Sets.newHashSet();
+ }
+
+ @Override
+ public Set<ConfigOption<?>> optionalOptions() {
+ final Set<ConfigOption<?>> options = Sets.newHashSet();
+ options.add(FactoryUtil.PROPERTY_VERSION);
+ return options;
+ }
+
@Override
public Map<String, String> requiredContext() {
Map<String, String> context = Maps.newHashMap();
- context.put(CatalogDescriptorValidator.CATALOG_TYPE, "iceberg");
- context.put(CatalogDescriptorValidator.CATALOG_PROPERTY_VERSION, "1");
+ context.put(TYPE, "iceberg");
+ context.put(PROPERTY_VERSION, "1");
Review comment:
@kbendick this `property-version` is indicating the flink connector's
properties version, not the apache iceberg table format, which is used for
guarantee the properties compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
