jackye1995 commented on a change in pull request #3207:
URL: https://github.com/apache/iceberg/pull/3207#discussion_r718930397
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/actions/BaseRewriteDataFilesSparkAction.java
##########
@@ -326,13 +333,35 @@ private void validateAndInitOptions() {
PARTIAL_PROGRESS_ENABLED,
PARTIAL_PROGRESS_ENABLED_DEFAULT);
+ removePartitionDeletes = PropertyUtil.propertyAsBoolean(options(),
+ REMOVE_PARTITION_DELETES,
+ REMOVE_PARTITION_DELETES_DEFAULT);
+
+ removeGlobalDeletes = PropertyUtil.propertyAsBoolean(options(),
+ REMOVE_GLOBAL_DELETES,
+ REMOVE_GLOBAL_DELETES_DEFAULT);
+
Preconditions.checkArgument(maxConcurrentFileGroupRewrites >= 1,
"Cannot set %s to %s, the value must be positive.",
MAX_CONCURRENT_FILE_GROUP_REWRITES, maxConcurrentFileGroupRewrites);
Preconditions.checkArgument(!partialProgressEnabled ||
partialProgressEnabled && maxCommits > 0,
"Cannot set %s to %s, the value must be positive when %s is true",
PARTIAL_PROGRESS_MAX_COMMITS, maxCommits, PARTIAL_PROGRESS_ENABLED);
+
+ Preconditions.checkArgument(removePartitionDeletes || !removeGlobalDeletes,
Review comment:
technically we can allow this case, but I don't know why people would
try to do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
