puneetzaroo commented on a change in pull request #3207:
URL: https://github.com/apache/iceberg/pull/3207#discussion_r739573729
##########
File path: core/src/main/java/org/apache/iceberg/actions/BinPackStrategy.java
##########
@@ -60,7 +60,9 @@
* {@link #MIN_FILE_SIZE_BYTES} will be considered for rewriting. This
functions independently
* of {@link #MAX_FILE_SIZE_BYTES}.
* <p>
- * Defaults to 75% of the target file size
+ * Defaults to 75% of the target file size when {@link
RewriteDataFiles#REMOVE_PARTITION_DELETES} and
Review comment:
I almost feel like there should be separate thresholds for delete
compaction. In other words if a data file is too small OR it has a lot of
delete files covering it; we should rewrite the data file. A file could be
correctly sized but in need of delete compaction as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
