puneetzaroo commented on pull request #3207: URL: https://github.com/apache/iceberg/pull/3207#issuecomment-955099216
> I think this may fit better as a completely separate strategy, just because we end up having to disable the min and max file size parameters. Just something like > > "RemoveDeletesStrategy" > > Which could extend BinPackStrategy and just wouldn't have Min and Max as valid options? Then we could just change the "select file method" > I think this may fit better as a completely separate strategy, just because we end up having to disable the min and max file size parameters. Just something like > > "RemoveDeletesStrategy" > > Which could extend BinPackStrategy and just wouldn't have Min and Max as valid options? Then we could just change the "select file method" I do think that will be cleaner as it will be obvious this strategy is meant for removing deletes. But just as a further point of clarification; this action is removing the need for delete files, right ; not actually removing the delete files as that i think has to be done more carefully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
